Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(go): update enum casing #3163

Merged
merged 1 commit into from
Jun 12, 2024
Merged

chore(go): update enum casing #3163

merged 1 commit into from
Jun 12, 2024

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Jun 11, 2024

🧭 What and Why

🎟 JIRA Ticket: DI-1641

Changes included:

  • Make enum have a upper snake case

@Fluf22 Fluf22 self-assigned this Jun 11, 2024
@Fluf22 Fluf22 requested a review from a team as a code owner June 11, 2024 16:26
@Fluf22 Fluf22 requested review from damcou and shortcuts June 11, 2024 16:26
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the DX is way better, thanks !

@Fluf22 Fluf22 force-pushed the chore/update-enum-casing branch from 341fc70 to a8045fd Compare June 12, 2024 10:42
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 12, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@Fluf22 Fluf22 requested a review from millotp June 12, 2024 10:44
@Fluf22
Copy link
Contributor Author

Fluf22 commented Jun 12, 2024

The rebase + conflict resolution was failing because JetBrains kept updating the go.mod+sum of the playground, which made me do the edit manually, and I must have missed something since some changes were reverted
I'll update again and push a fix

@Fluf22 Fluf22 force-pushed the chore/update-enum-casing branch from a8045fd to 8795fbc Compare June 12, 2024 11:28
Copy link

@github-actions github-actions bot temporarily deployed to pull request June 12, 2024 11:43 Inactive
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful !

@Fluf22 Fluf22 merged commit 39eb92b into main Jun 12, 2024
25 checks passed
@Fluf22 Fluf22 deleted the chore/update-enum-casing branch June 12, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants