Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(go): upgrade the linter #3140

Merged
merged 1 commit into from
Jun 6, 2024
Merged

fix(go): upgrade the linter #3140

merged 1 commit into from
Jun 6, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jun 6, 2024

🧭 What and Why

The go linter has finally added a option to lint generated file so we can remove the exception

@millotp millotp self-assigned this Jun 6, 2024
@millotp millotp requested a review from a team as a code owner June 6, 2024 09:25
@millotp millotp requested review from morganleroi and shortcuts June 6, 2024 09:25
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 6, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

shortcuts
shortcuts approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

🚀 Deployed on https://6661a95ac215e9233ff9754c--api-clients-automation.netlify.app

@github-actions github-actions bot temporarily deployed to pull request June 6, 2024 12:19 Inactive
@millotp millotp merged commit 34a1694 into main Jun 6, 2024
25 checks passed
@millotp millotp deleted the fix/upgrade-golangci-lint branch June 6, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@millotp millotp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@millotp @algolia-bot @shortcuts