Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade deps #300

Merged
merged 5 commits into from
Mar 28, 2022
Merged

chore: upgrade deps #300

merged 5 commits into from
Mar 28, 2022

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Mar 28, 2022

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-394

Changes included:

There was bug fixes on @redocly/openapi-cli and redocusaurus, so I've added the @yarnpkg/plugin-interactive-tools to upgrade deps and also upgraded the ones that did not require changes.

🧪 Test

CI :D

@shortcuts shortcuts self-assigned this Mar 28, 2022
@netlify
Copy link

netlify bot commented Mar 28, 2022

Deploy Preview for api-clients-automation failed.

Name Link
🔨 Latest commit bf3766e
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/6241c16d4e8da50009aef4fe

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can hear renovate calling in the background, might be time to add it ahah

@@ -1 +1 @@
6
6.0.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol semantic versioning on the cache

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷🏼

@@ -1,3 +1,7 @@
nodeLinker: node-modules

plugins:
- path: .yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn already includes a tool to upgrade deps, yarn up "*" -iE, are you sure this plugin is necessary ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah good to know, I'll check if it's the same, I like this one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the plugin better, you can check from this PR the difference

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree the plugins looks better

package.json Outdated
@@ -23,31 +23,31 @@
"scripts:lint": "eslint --ext=ts scripts/",
"scripts:test": "yarn workspace scripts test",
"specs:fix": "eslint --ext=yml specs/ --fix",
"specs:lint": "eslint --ext=yml specs/$0",
"specs:lint": "eslint --ext=yml specs/$0 --fix",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the command above is supposed to fix it already, this is only used on the CI

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've now updated it to only fix the bundled one 6bd7985

@algolia-bot
Copy link
Collaborator

algolia-bot commented Mar 28, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the generated/main branch.

@algolia algolia deleted a comment from algolia-bot Mar 28, 2022
@algolia algolia deleted a comment from algolia-bot Mar 28, 2022
@shortcuts shortcuts merged commit ad260df into main Mar 28, 2022
@shortcuts shortcuts deleted the chore/upgrade-deps branch March 28, 2022 14:29
algolia-bot pushed a commit to algolia/algoliasearch-client-javascript that referenced this pull request Mar 28, 2022
algolia/api-clients-automation#300

Co-authored-by: Clément Vannicatte <20689156+shortcuts@users.noreply.github.com>
shortcuts added a commit that referenced this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants