-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade deps #300
chore: upgrade deps #300
Conversation
❌ Deploy Preview for api-clients-automation failed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can hear renovate
calling in the background, might be time to add it ahah
@@ -1 +1 @@ | |||
6 | |||
6.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol semantic versioning on the cache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷🏼
@@ -1,3 +1,7 @@ | |||
nodeLinker: node-modules | |||
|
|||
plugins: | |||
- path: .yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yarn
already includes a tool to upgrade deps, yarn up "*" -iE
, are you sure this plugin is necessary ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah good to know, I'll check if it's the same, I like this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the plugin better, you can check from this PR the difference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree the plugins looks better
package.json
Outdated
@@ -23,31 +23,31 @@ | |||
"scripts:lint": "eslint --ext=ts scripts/", | |||
"scripts:test": "yarn workspace scripts test", | |||
"specs:fix": "eslint --ext=yml specs/ --fix", | |||
"specs:lint": "eslint --ext=yml specs/$0", | |||
"specs:lint": "eslint --ext=yml specs/$0 --fix", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the command above is supposed to fix it already, this is only used on the CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've now updated it to only fix the bundled one 6bd7985
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
algolia/api-clients-automation#300 Co-authored-by: Clément Vannicatte <20689156+shortcuts@users.noreply.github.com>
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-394
Changes included:
There was bug fixes on
@redocly/openapi-cli
andredocusaurus
, so I've added the@yarnpkg/plugin-interactive-tools
to upgrade deps and also upgraded the ones that did not require changes.🧪 Test
CI :D