Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make codegen message cleaner #293

Merged
merged 1 commit into from
Mar 24, 2022
Merged

chore: make codegen message cleaner #293

merged 1 commit into from
Mar 24, 2022

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

Copies Netlify style for the generated commit message, table seems easier to understand

🧪 Test

CI :D

@shortcuts shortcuts requested a review from a team March 24, 2022 16:20
@shortcuts shortcuts self-assigned this Mar 24, 2022
@shortcuts shortcuts requested review from eunjae-lee and damcou and removed request for a team March 24, 2022 16:20
@netlify
Copy link

netlify bot commented Mar 24, 2022 •
edited
Loading

✅ Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit d3b967c
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/623c9a376d4ebc00082cad7e

millotp
millotp approved these changes Mar 24, 2022
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful !

@shortcuts
Copy link
Member Author

shortcuts commented Mar 24, 2022 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the generated/main branch.

@shortcuts shortcuts enabled auto-merge (squash) March 24, 2022 18:01
@shortcuts shortcuts merged commit 8650fe4 into main Mar 24, 2022
@shortcuts shortcuts deleted the chore/better-codegen-message branch March 24, 2022 18:01
shortcuts added a commit that referenced this pull request Apr 22, 2022
@shortcuts
chore: make codegen message cleaner (#293)
5fef700
This was referenced May 24, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@eunjae-lee eunjae-lee Awaiting requested review from eunjae-lee eunjae-lee is a code owner automatically assigned from algolia/api-clients-automation

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shortcuts @millotp