-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(specs): make languages an enum #2865
Conversation
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
Inre-run the Kotlin one to check it wasn't just a one-off error |
It seems kotlin doesn't understand the oneOf anymore, now that there is a $ref in one of the element... |
Sorry about the additional work and thanks. |
I found the issue for Swift, I'm gonna push a fix |
I found the issue for Kotlin, I'm gonna try to push a fix 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🆗
@Fluf22 thanks for doing this! I don't have permissions to merge PRs on this repo. Could you merge it for me please? |
🧭 What and Why
Restrict allowed languages for settings like
queryLanguages
andindexLanguages
to the list of supported languages, as currently the clients suggest that all string values are accepted, which would lead to errors when using.Changes included:
supportedLanguage
indexLanguages
,queryLanguages
,removeStopWords
,ignorePlurals
, and the dictionary response to be ofsupportedLanguage
type.🧪 Test