Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(go): add missing ACLs in description, remove duplicated deprecation notice #2825

Merged
merged 2 commits into from
Mar 4, 2024
Merged

chore(go): add missing ACLs in description, remove duplicated deprecation notice #2825

merged 2 commits into from
Mar 4, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

  • deprecated was written twice
  • the method with context did not had the ACL comment

@shortcuts shortcuts self-assigned this Mar 4, 2024
@shortcuts shortcuts requested a review from a team as a code owner March 4, 2024 13:15
@shortcuts shortcuts requested review from damcou and millotp March 4, 2024 13:15
@algolia-bot
Copy link
Collaborator

algolia-bot commented Mar 4, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

🚀 Deployed on https://65e5d2c47a6727291bdd03f4--api-clients-automation.netlify.app

@github-actions github-actions bot temporarily deployed to pull request March 4, 2024 13:25 Inactive
millotp
millotp approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch !

@shortcuts shortcuts enabled auto-merge (squash) March 4, 2024 13:46
@github-actions github-actions bot temporarily deployed to pull request March 4, 2024 13:55 Inactive
@shortcuts shortcuts merged commit 115dd17 into main Mar 4, 2024
12 checks passed
@shortcuts shortcuts deleted the chore/go-templates branch March 4, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shortcuts @algolia-bot @millotp