Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(go): add generateSecuredApiKey helper #2797

Merged
merged 4 commits into from
Feb 28, 2024
Merged

feat(go): add generateSecuredApiKey helper #2797

merged 4 commits into from
Feb 28, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Feb 28, 2024 •
edited
Loading

🧭 What and Why

🎟 JIRA Ticket: DI-1782

Add GenerateSecuredApiKey to the go client, also fix the type and the playground

@millotp millotp self-assigned this Feb 28, 2024
@millotp millotp requested a review from a team as a code owner February 28, 2024 10:07
@netlify Netlify
Copy link

netlify bot commented Feb 28, 2024 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit e234d07
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65df15bd6be8e800080b74f7
😎 Deploy Preview https://deploy-preview-2797--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Feb 28, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

morganleroi
morganleroi previously approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@morganleroi morganleroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you manage to try it in real condition to see if the Search API accept the key and correctly applies to restrictions ? (Even with randomness)

@millotp
Copy link
Collaborator Author

millotp commented Feb 28, 2024

yes it's working well now, thanks for making me test !

@millotp millotp requested a review from morganleroi February 28, 2024 11:15
morganleroi
morganleroi approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@morganleroi morganleroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼

shortcuts
shortcuts approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! The description of the pr needs to be updated but no biggy

@millotp
Copy link
Collaborator Author

millotp commented Feb 28, 2024

The description of the pr needs to be updated but no biggy

updated !

@millotp millotp merged commit 7a2d369 into main Feb 28, 2024
28 checks passed
@millotp millotp deleted the feat/go-api-key branch February 28, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morganleroi morganleroi morganleroi approved these changes

@shortcuts shortcuts shortcuts approved these changes

Assignees

@millotp millotp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@millotp @algolia-bot @morganleroi @shortcuts