-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(php): add chunkedBatch
method
#2796
Conversation
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a unit test to check that we do call X times method and correctly chunk the batch ?
Where are we regarding helper tests ? I see that only a few languages have them, shouldn't we wait for the helpers to be added to the specs before adding them ? |
you can follow python and javascript they should be fairly close to reality, errors will be fixed in an upcoming pr from @millotp |
Seems weird to me to push code without associated tests. Even if helpers signature will be generated, you will have to implement the test. Up to you. |
Since it's not only about this method, I'll dedicate a whole ticket/PR about helper tests (it may take a while) |
🧭 What and Why
🎟 JIRA Ticket: DI-1832
Changes included:
chunkedBatch
and use it inreplaceAllObjects