Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(php): add chunkedBatch method #2796

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Conversation

damcou
Copy link
Contributor

@damcou damcou commented Feb 27, 2024

🧭 What and Why

🎟 JIRA Ticket: DI-1832

Changes included:

  • Add method chunkedBatch and use it in replaceAllObjects

@damcou damcou self-assigned this Feb 27, 2024
@damcou damcou requested a review from a team as a code owner February 27, 2024 15:50
Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 4561b7d
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65de04b5489ccc0008e8a005
😎 Deploy Preview https://deploy-preview-2796--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Feb 27, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@damcou damcou requested a review from shortcuts February 27, 2024 15:51
Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 8936029
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65defcfe91ea3900085e088a
😎 Deploy Preview https://deploy-preview-2796--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@morganleroi morganleroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a unit test to check that we do call X times method and correctly chunk the batch ?

@damcou
Copy link
Contributor Author

damcou commented Feb 27, 2024

Can you add a unit test to check that we do call X times method and correctly chunk the batch ?

Where are we regarding helper tests ? I see that only a few languages have them, shouldn't we wait for the helpers to be added to the specs before adding them ?

@shortcuts
Copy link
Member

Can you add a unit test to check that we do call X times method and correctly chunk the batch ?

Where are we regarding helper tests ? I see that only a few languages have them, shouldn't we wait for the helpers to be added to the specs before adding them ?

you can follow python and javascript they should be fairly close to reality, errors will be fixed in an upcoming pr from @millotp

@morganleroi
Copy link
Contributor

Seems weird to me to push code without associated tests. Even if helpers signature will be generated, you will have to implement the test. Up to you.

@damcou
Copy link
Contributor Author

damcou commented Feb 27, 2024

Since it's not only about this method, I'll dedicate a whole ticket/PR about helper tests (it may take a while)

@damcou damcou requested a review from morganleroi February 28, 2024 09:32
@damcou damcou merged commit 608fd29 into main Feb 28, 2024
15 checks passed
@damcou damcou deleted the feat/DI-1832/chunkedbatch-php branch February 28, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants