Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): add missing attributes for CT Source update #2792

Merged
merged 4 commits into from
Feb 27, 2024
Merged

fix(specs): add missing attributes for CT Source update #2792

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9e8ceb
fix(specs): add missing attributes for CT Source update
damcou Feb 27, 2024
9235cfc
fix(specs): add missing attributes for CT Source update
damcou Feb 27, 2024
7197559
fix(specs): add missing attributes for CT Source update
damcou Feb 27, 2024
1dae7fe
fix(specs): add missing attributes for CT Source update
damcou Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions specs/ingestion/common/schemas/source.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,8 +373,16 @@ SourceUpdateCommercetools:
Array of locales that must match the following pattern: ^[a-z]{2}(-[A-Z]{2})?$. For example ["fr-FR", "en"].
items:
type: string
url:
type: string
fallbackIsInStockValue:
type: boolean
description: >
Determines the value that will be stored in the Algolia record if there's no inventory information on the product.
customFields:
$ref: '#/CommercetoolsCustomFields'
required:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the goal of the update is not to have required properties

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, please, I just want to close my PR about the custom fields...

- url

SourceUpdateInput:
oneOf:
Expand Down
Loading