Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clients): replace all objects #2762

Merged
merged 2 commits into from
Feb 22, 2024
Merged

fix(clients): replace all objects #2762

merged 2 commits into from
Feb 22, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

fix wait for python and chsarp, kotlin is already right, php is less wrong

@shortcuts shortcuts self-assigned this Feb 22, 2024
@shortcuts shortcuts requested a review from a team as a code owner February 22, 2024 15:29
Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 6455a6a
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65d76ba4b59ef10008637b54
😎 Deploy Preview https://deploy-preview-2762--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Feb 22, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

millotp
millotp previously approved these changes Feb 22, 2024
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this is the correct arrangement !

@shortcuts
Copy link
Member Author

I hope this is the correct arrangement !

so from the tests I've made................. weirdly it doesn't matter much in that case but I guess it's because it's pretty fast still

however looking at the current JS implementation, this is the correct way

@morganleroi
Copy link
Contributor

image

🤣

@shortcuts shortcuts enabled auto-merge (squash) February 22, 2024 15:52
@shortcuts shortcuts requested a review from millotp February 22, 2024 16:06
Copy link
Contributor

@morganleroi morganleroi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks A LOT

@shortcuts shortcuts merged commit f3e8940 into main Feb 22, 2024
15 checks passed
@shortcuts shortcuts deleted the fix/replaceallobjects branch February 22, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants