Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(swift): add snippets #2705

Merged
merged 2 commits into from
Feb 13, 2024
Merged

feat(swift): add snippets #2705

merged 2 commits into from
Feb 13, 2024

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Feb 12, 2024 •
edited by jira bot
Loading

🧭 What and Why

🎟 JIRA Ticket: DI-1793

Changes included:

  • add snippets gen

@Fluf22 Fluf22 self-assigned this Feb 12, 2024
@Fluf22 Fluf22 requested a review from a team as a code owner February 12, 2024 19:57
@netlify Netlify
Copy link

netlify bot commented Feb 12, 2024 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 20bc949
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65cb5831c94c9b0008da0451
😎 Deploy Preview https://deploy-preview-2705--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Feb 12, 2024 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

millotp
millotp reviewed Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the formatter is running on the generated snippet ahah

@Fluf22 Fluf22 force-pushed the feat/swift-snippets-gen branch from 7da366b to 87e2f9d Compare February 13, 2024 11:01
@Fluf22 Fluf22 force-pushed the feat/swift-snippets-gen branch from 87e2f9d to a82cf60 Compare February 13, 2024 11:01
millotp
millotp approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gg !

@Fluf22 Fluf22 merged commit f2840ec into main Feb 13, 2024
26 checks passed
@Fluf22 Fluf22 deleted the feat/swift-snippets-gen branch February 13, 2024 13:14
millotp pushed a commit that referenced this pull request Feb 14, 2024
@Fluf22 @millotp
feat(swift): add snippets (#2705)
c034dc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

@shortcuts shortcuts Awaiting requested review from shortcuts shortcuts is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@Fluf22 Fluf22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fluf22 @algolia-bot @millotp