fix(cts): strict comparaison of query parameters #2681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
|
Do I need to double check if all assertion are correctly done in C# ? |
|
I checked for all languages, but maybe I got some wrong ! |
This was referenced Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Unknown query parameters are not allowed in most APIs, we need to make sure that the client only sends what was requested, and nothing else.
Enforce strict check in all languages, and fix python by initializing every member of a class, otherwise they are treated as static member ! (so weird)
No need to initialize models for python, because they all extend the
BaseModelwhich initializes everything properly (from what I understand, maybe I'm wrong).also some small fixes in other languages to make the CI pass, and locally too.