Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cts): add e2e for abtesting #2673

Merged
merged 11 commits into from
Feb 13, 2024
Merged

fix(cts): add e2e for abtesting #2673

merged 11 commits into from
Feb 13, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Feb 6, 2024

🧭 What and Why

Add an e2e for abtesting that uses a space in the query parameters, to make sure it works with the new encoding.
AB Tests can only last 90 days however, so we need to recreate an abtest an update this test every 3 month, might be worth to automate it.

Here is the request to create the abtest with the addABTests endpoint:

 {
    "endAt": "2024-05-06T09:04:26.469Z", // update this to be NOW + 90 days
    "name": "cts_e2e_abtest",
    "variants": [
      {
        "index": "cts_e2e_search_facet",
        "trafficPercentage": 25
      },
      {
        "index": "cts_e2e abtest",
        "trafficPercentage": 75
      }
    ]
  }

@millotp millotp self-assigned this Feb 6, 2024
@millotp millotp requested a review from a team as a code owner February 6, 2024 10:13
@millotp millotp requested review from damcou and Fluf22 February 6, 2024 10:13
Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit b3197f2
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65cb4ad3586ef60008eca7c3
😎 Deploy Preview https://deploy-preview-2673--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Feb 6, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Fluf22
Fluf22 previously approved these changes Feb 6, 2024
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

Fluf22
Fluf22 previously approved these changes Feb 6, 2024
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is totally gonna conflict with my current PR :lolsob:

Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally

@millotp millotp merged commit f7da97b into main Feb 13, 2024
26 checks passed
@millotp millotp deleted the fix/abtest-e2e branch February 13, 2024 11:21
millotp added a commit that referenced this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants