Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): kotlin release #2649

Merged
merged 6 commits into from
Feb 2, 2024
Merged

fix(scripts): kotlin release #2649

merged 6 commits into from
Feb 2, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Feb 2, 2024

🧭 What and Why

Kotlin and scala release are broken, and the CI is not waiting long enough for them to complete.
Also fix small bugs

@millotp millotp self-assigned this Feb 2, 2024
@millotp millotp requested a review from a team as a code owner February 2, 2024 15:59
@millotp millotp requested review from damcou and morganleroi February 2, 2024 15:59
Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 2c1a81e
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65bd2496ee995200089efa1d
😎 Deploy Preview https://deploy-preview-2649--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Feb 2, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

morganleroi
morganleroi previously approved these changes Feb 2, 2024
@@ -79,7 +79,8 @@ async function waitForAllReleases(languages: Language[]): Promise<void> {
const failures: Language[] = [];

const start = Date.now();
while (Date.now() - start < 1000 * 60 * 5) {
// kotlin release can take a long time
while (Date.now() - start < 1000 * 60 * 10) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

Copy link
Collaborator Author

@millotp millotp Feb 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's running on a macos github actions !

@millotp millotp enabled auto-merge (squash) February 2, 2024 17:21
@millotp millotp merged commit d9c0caf into main Feb 2, 2024
28 checks passed
@millotp millotp deleted the fix/small branch February 2, 2024 17:32
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Feb 2, 2024
algolia/api-clients-automation#2649

Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Feb 2, 2024
algolia/api-clients-automation#2649

Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants