Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump package version #264

Merged
merged 8 commits into from
Mar 21, 2022
Merged

chore: bump package version #264

merged 8 commits into from
Mar 21, 2022

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

I just released the 0.0.5 version manually, which requires deps versions to be bumped.

This PR also:

  • Removes the inlined version from the getting started CDN link.
  • Removes duplicate algoliasearch in the scripts CLI.

🧪 Test

CI :D

@shortcuts shortcuts requested review from eunjae-lee and millotp March 17, 2022 12:17
@shortcuts shortcuts self-assigned this Mar 17, 2022
@netlify
Copy link

netlify bot commented Mar 17, 2022

✅ Deploy Preview for api-clients-automation canceled.

🔨 Explore the source changes: 0a9387d

🔍 Inspect the deploy log: https://app.netlify.com/sites/api-clients-automation/deploys/6238492f0d9c1c000968d385

@shortcuts
Copy link
Member Author

Ah yes, the yarn lock bump should be included the generated code 🤔

@shortcuts
Copy link
Member Author

shortcuts commented Mar 17, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the generated/main branch.

@shortcuts shortcuts requested review from a team, eunjae-lee and damcou and removed request for eunjae-lee, millotp and a team March 17, 2022 12:33
@shortcuts
Copy link
Member Author

._. I did not wanted that

@shortcuts shortcuts reopened this Mar 17, 2022
millotp
millotp previously approved these changes Mar 17, 2022
bodinsamuel
bodinsamuel previously approved these changes Mar 17, 2022
@shortcuts
Copy link
Member Author

I think the codegen CI will fail in that case because the yarn.lock will try to pick remote versions 🤔

Since it's only temporary I won't bother fix it and just push generated code directly. Do you think we will have the issue with the release process @eunjae-lee ?

@eunjae-lee
Copy link
Contributor

I think the codegen CI will fail in that case because the yarn.lock will try to pick remote versions 🤔

Since it's only temporary I won't bother fix it and just push generated code directly. Do you think we will have the issue with the release process @eunjae-lee ?

As I said in DM, I think it should be okay. Let's go! 🚀

eunjae-lee
eunjae-lee previously approved these changes Mar 17, 2022
@shortcuts
Copy link
Member Author

Checking in #266 if it's really a lock error or race condition as we've seen on the CLI

@shortcuts
Copy link
Member Author

As I said in DM, I think it should be okay. Let's go! 🚀

Actually, after more testing, I found two case where it would have fail:

  • Bumping versions like I did here (which shouldn't happen once the release process is done)
  • Bumping an utils package and generating code via the CI

It should now all work

@shortcuts shortcuts enabled auto-merge (squash) March 21, 2022 10:11
Comment on lines +205 to +210
'clients/algoliasearch-client-javascript/packages/client-search/src/**',
'clients/algoliasearch-client-javascript/packages/client-search/model/**',
'clients/algoliasearch-client-javascript/packages/client-search/builds/**',
'clients/algoliasearch-client-javascript/packages/client-search/package.json',
'specs/bundled/search.yml',
'templates/javascript/**'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think if there's any way to avoid listing all the paths like this? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Negative patterns does not work properly... So I don't think so :( At least I did not found a better way to both make it clean and working

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. It's not a blocker here, but in a separate PR, we should find a way to improve this before it gets too difficult to manage 😬

Copy link
Member Author

@shortcuts shortcuts Mar 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep definitely, we also have a task in the backlog to improve the cache key, we should tackle it once we have a bit of time

@eunjae-lee
Copy link
Contributor

  • Bumping an utils package and generating code via the CI

I think this will be covered by https://github.com/algolia/api-clients-automation/pull/248/files#diff-15803d489054332c299ad7414e40a62f6034aacdd68eb614d0a920c73de0b08cR191-R206 :)

@shortcuts shortcuts merged commit 66987c6 into main Mar 21, 2022
@shortcuts shortcuts deleted the chore/release-js-update branch March 21, 2022 10:22
@shortcuts
Copy link
Member Author

I think this will be covered by https://github.com/algolia/api-clients-automation/pull/248/files#diff-15803d489054332c299ad7414e40a62f6034aacdd68eb614d0a920c73de0b08cR191-R206 :)

But it's done on the CI side, right? So running a yarn install to update the lock file would've throw anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants