-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump package version #264
Conversation
✅ Deploy Preview for api-clients-automation canceled. 🔨 Explore the source changes: 0a9387d 🔍 Inspect the deploy log: https://app.netlify.com/sites/api-clients-automation/deploys/6238492f0d9c1c000968d385 |
Ah yes, the yarn lock bump should be included the generated code 🤔 |
✗ The generated branch has been deleted. If the PR has been merged, you can check the generated code on the |
._. I did not wanted that |
I think the codegen CI will fail in that case because the Since it's only temporary I won't bother fix it and just push generated code directly. Do you think we will have the issue with the release process @eunjae-lee ? |
As I said in DM, I think it should be okay. Let's go! 🚀 |
Checking in #266 if it's really a lock error or race condition as we've seen on the CLI |
Actually, after more testing, I found two case where it would have fail:
It should now all work |
'clients/algoliasearch-client-javascript/packages/client-search/src/**', | ||
'clients/algoliasearch-client-javascript/packages/client-search/model/**', | ||
'clients/algoliasearch-client-javascript/packages/client-search/builds/**', | ||
'clients/algoliasearch-client-javascript/packages/client-search/package.json', | ||
'specs/bundled/search.yml', | ||
'templates/javascript/**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think if there's any way to avoid listing all the paths like this? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Negative patterns does not work properly... So I don't think so :( At least I did not found a better way to both make it clean and working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. It's not a blocker here, but in a separate PR, we should find a way to improve this before it gets too difficult to manage 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep definitely, we also have a task in the backlog to improve the cache key, we should tackle it once we have a bit of time
I think this will be covered by https://github.com/algolia/api-clients-automation/pull/248/files#diff-15803d489054332c299ad7414e40a62f6034aacdd68eb614d0a920c73de0b08cR191-R206 :) |
But it's done on the CI side, right? So running a |
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
I just released the
0.0.5
version manually, which requires deps versions to be bumped.This PR also:
getting started
CDN link.algoliasearch
in the scripts CLI.🧪 Test
CI :D