Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lint): don't lint ts with prettier #26

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Dec 2, 2021

🧭 What and Why

Prettier and eslint does the same job, and running both generate the same output, so I've remove prettier for ts linting,
this reduce the time to run yarn generate by a whopping 9% !! (it's insignificant)

Changes included:

  • Remove prettier for ts

🧪 Test

  • time yarn generate

@millotp millotp requested a review from shortcuts December 2, 2021 12:37
@millotp millotp self-assigned this Dec 2, 2021
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:very_nice:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants