chore: support fish for setup #2545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shortcuts
commented
Jan 15, 2024
Comment on lines
+5
to
+8
| while read line; do | ||
| arr=($line) | ||
| export $(echo ${arr[1]} | sed -e "s/-/_/;s/config\/\.//" | tr "[a-z]" "[A-Z]")=${arr[0]} | ||
| done < <(find config -name '.*-version' -exec jq --raw-input -r '. + " " + input_filename' {} \;) |
There was a problem hiding this comment.
i can't remember how to do a while on 2 variables outputted by jq so I used a space to split it 🤷🏻 that's fineeee
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
you can't setup docker with fish actually because it sets the env var from substitutions, but with bass (fish plugin) it works if we use export directly in the script we are running