Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go): use better parameters #2514

Merged
merged 12 commits into from
Jan 15, 2024
Merged

fix(go): use better parameters #2514

merged 12 commits into from
Jan 15, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jan 10, 2024

🧭 What and Why

Make the go CTS use the real models, and not just the json.
This involves reworking a lot of the types because it's a mess between pointer and not pointer.

@millotp millotp self-assigned this Jan 10, 2024
Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit dd4fe5c
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65a553bc16ac1a00084fab5d
😎 Deploy Preview https://deploy-preview-2514--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 10, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@millotp millotp marked this pull request as ready for review January 15, 2024 15:27
@millotp millotp requested a review from a team as a code owner January 15, 2024 15:27
@millotp millotp requested review from damcou and morganleroi January 15, 2024 15:27
@morganleroi
Copy link
Contributor

Huuuuuge

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feat fixes and chore

in-sane gg

@millotp millotp merged commit 0bb2c80 into main Jan 15, 2024
28 checks passed
@millotp millotp deleted the fix/rework-go-cts branch January 15, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants