Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add release process for js repository #251

Merged
merged 16 commits into from
Mar 21, 2022
Merged

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Mar 14, 2022

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-299

Changes included:

  • Publish to NPM when a commit starting with release: chore v is added.

@netlify
Copy link

netlify bot commented Mar 14, 2022

✅ Deploy Preview for api-clients-automation canceled.

🔨 Explore the source changes: 7255dd7

🔍 Inspect the deploy log: https://app.netlify.com/sites/api-clients-automation/deploys/62388441d6ab3300099d5daf

@eunjae-lee eunjae-lee changed the title Chore/release-js chore(ci): add release process for js repository Mar 14, 2022
@eunjae-lee eunjae-lee marked this pull request as ready for review March 15, 2022 10:17
@eunjae-lee eunjae-lee requested review from a team, damcou and millotp and removed request for a team March 15, 2022 10:19
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I just think it should be in TypeScript :D

@eunjae-lee eunjae-lee requested a review from shortcuts March 16, 2022 09:22
@shortcuts
Copy link
Member

shortcuts commented Mar 17, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the generated/main branch.

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good too!

eunjae-lee and others added 2 commits March 21, 2022 10:48
Co-authored-by: Clément Vannicatte <20689156+shortcuts@users.noreply.github.com>
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait to test :D

@eunjae-lee eunjae-lee enabled auto-merge (squash) March 21, 2022 13:57
@eunjae-lee eunjae-lee merged commit 0f9b48f into main Mar 21, 2022
@eunjae-lee eunjae-lee deleted the chore/release-js branch March 21, 2022 14:05
shortcuts added a commit that referenced this pull request Apr 22, 2022
* chore(ci): add release process for js repository

* chore: rename

* chore: update github action

* chore: restore test version

* chore: pin devDep

* chore: clean up code

* chore: convert to typescript

* chore: remove version from umbrella package.json for js packages

* Update clients/algoliasearch-client-javascript/scripts/publish.ts

Co-authored-by: Clément Vannicatte <20689156+shortcuts@users.noreply.github.com>

* chore: include .npmrc

Co-authored-by: Clément Vannicatte <20689156+shortcuts@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants