Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): make ci push generated code #244

Merged
merged 6 commits into from
Mar 14, 2022
Merged

feat(ci): make ci push generated code #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8f3272a
feat(ci): make ci push generated code
shortcuts Mar 9, 2022
a8d9aa6
apply changes from suggestion
shortcuts Mar 10, 2022
01733bc
bump caches?
shortcuts Mar 10, 2022
2344eb8
replace status with diff
shortcuts Mar 14, 2022
b1d5dea
inline headRef parameter
shortcuts Mar 14, 2022
79d650f
Merge branch 'main' into feat/ci-generated-code
shortcuts Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
152 changes: 137 additions & 15 deletions .github/actions/cache/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,115 @@ runs:
shell: bash
run: curl -L "https://repo1.maven.org/maven2/org/openapitools/openapi-generator-cli/5.4.0/openapi-generator-cli-5.4.0.jar" > /tmp/openapi-generator-cli.jar

# Restore bundled specs: used during 'client' generation or pushing the 'codegen'
- name: Restore built abtesting spec
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are those cached here ? I think we have duplication between bundled and dist, and if this needs to be cached I think it should be part of .gitignore too, so that we don't have to gen them ourself

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are those cached here ?

They are cached as generated clients, for now the CI will only push bundled specs and generated clients. We shouldn't push them anymore too.

Ideally, we should have the same part for the CTS

if: ${{ inputs.job == 'client' || inputs.job == 'codegen' }}
uses: actions/cache@v2
with:
path: specs/bundled/abtesting.yml
key: |
${{ env.CACHE_VERSION }}-${{
hashFiles(
'specs/abtesting/**',
'specs/common/**'
)}}

- name: Restore built analytics spec
if: ${{ inputs.job == 'client' || inputs.job == 'codegen' }}
uses: actions/cache@v2
with:
path: specs/bundled/analytics.yml
key: |
${{ env.CACHE_VERSION }}-${{
hashFiles(
'specs/analytics/**',
'specs/common/**'
)}}

- name: Restore built insights spec
if: ${{ inputs.job == 'client' || inputs.job == 'codegen' }}
uses: actions/cache@v2
with:
path: specs/bundled/insights.yml
key: |
${{ env.CACHE_VERSION }}-${{
hashFiles(
'specs/insights/**',
'specs/common/**'
)}}

- name: Restore built personalization spec
if: ${{ inputs.job == 'client' || inputs.job == 'codegen' }}
uses: actions/cache@v2
with:
path: specs/bundled/personalization.yml
key: |
${{ env.CACHE_VERSION }}-${{
hashFiles(
'specs/personalization/**',
'specs/common/**'
)}}

- name: Restore built predict spec
if: ${{ inputs.job == 'client' || inputs.job == 'codegen' }}
uses: actions/cache@v2
with:
path: specs/bundled/predict.yml
key: |
${{ env.CACHE_VERSION }}-${{
hashFiles(
'specs/predict/**',
'specs/common/**'
)}}

- name: Restore built query-suggestions spec
if: ${{ inputs.job == 'client' || inputs.job == 'codegen' }}
uses: actions/cache@v2
with:
path: specs/bundled/query-suggestions.yml
key: |
${{ env.CACHE_VERSION }}-${{
hashFiles(
'specs/query-suggestions/**',
'specs/common/**'
)}}

- name: Restore built recommend spec
if: ${{ inputs.job == 'client' || inputs.job == 'codegen' }}
uses: actions/cache@v2
with:
path: specs/bundled/recommend.yml
key: |
${{ env.CACHE_VERSION }}-${{
hashFiles(
'specs/recommend/**',
'specs/common/**'
)}}

- name: Restore built search spec
if: ${{ inputs.job == 'client' || inputs.job == 'codegen' }}
uses: actions/cache@v2
with:
path: specs/bundled/search.yml
key: |
${{ env.CACHE_VERSION }}-${{
hashFiles(
'specs/search/**',
'specs/common/**'
)}}

- name: Restore built sources spec
if: ${{ inputs.job == 'client' || inputs.job == 'codegen' }}
uses: actions/cache@v2
with:
path: specs/bundled/sources.yml
key: |
${{ env.CACHE_VERSION }}-${{
hashFiles(
'specs/sources/**',
'specs/common/**'
)}}

# Restore JavaScript clients utils: used during 'javascript' generation or 'cts'
- name: Restore built JavaScript common client
if: ${{ inputs.language == 'javascript' || inputs.job == 'cts' }}
Expand Down Expand Up @@ -77,9 +186,9 @@ runs:
'!clients/algoliasearch-client-javascript/packages/requester-browser-xhr/dist'
)}}

# Restore JavaScript clients: used during 'cts'
# Restore JavaScript clients: used during 'cts' or 'codegen'
- name: Restore built JavaScript algoliasearch client
if: ${{ inputs.job == 'cts'}}
if: ${{ inputs.job == 'cts' || inputs.job == 'codegen' }}
uses: actions/cache@v2
with:
path: clients/algoliasearch-client-javascript/packages/algoliasearch
Expand All @@ -91,7 +200,7 @@ runs:
)}}

- name: Restore built JavaScript search client
if: ${{ inputs.job == 'cts' }}
if: ${{ inputs.job == 'cts' || inputs.job == 'codegen' }}
uses: actions/cache@v2
with:
path: clients/algoliasearch-client-javascript/packages/client-search
Expand All @@ -104,7 +213,7 @@ runs:
)}}

- name: Restore built JavaScript recommend client
if: ${{ inputs.job == 'cts' }}
if: ${{ inputs.job == 'cts' || inputs.job == 'codegen' }}
uses: actions/cache@v2
with:
path: clients/algoliasearch-client-javascript/packages/recommend
Expand All @@ -117,7 +226,7 @@ runs:
)}}

- name: Restore built JavaScript query-suggestions client
if: ${{ inputs.job == 'cts' }}
if: ${{ inputs.job == 'cts' || inputs.job == 'codegen' }}
uses: actions/cache@v2
with:
path: clients/algoliasearch-client-javascript/packages/client-query-suggestions
Expand All @@ -130,7 +239,7 @@ runs:
)}}

- name: Restore built JavaScript personalization client
if: ${{ inputs.job == 'cts' }}
if: ${{ inputs.job == 'cts' || inputs.job == 'codegen' }}
uses: actions/cache@v2
with:
path: clients/algoliasearch-client-javascript/packages/client-personalization
Expand All @@ -143,7 +252,7 @@ runs:
)}}

- name: Restore built JavaScript analytics client
if: ${{ inputs.job == 'cts' }}
if: ${{ inputs.job == 'cts' || inputs.job == 'codegen' }}
uses: actions/cache@v2
with:
path: clients/algoliasearch-client-javascript/packages/client-analytics
Expand All @@ -156,7 +265,7 @@ runs:
)}}

- name: Restore built JavaScript abtesting client
if: ${{ inputs.job == 'cts' }}
if: ${{ inputs.job == 'cts' || inputs.job == 'codegen' }}
uses: actions/cache@v2
with:
path: clients/algoliasearch-client-javascript/packages/client-abtesting
Expand All @@ -169,7 +278,7 @@ runs:
)}}

- name: Restore built JavaScript insights client
if: ${{ inputs.job == 'cts' }}
if: ${{ inputs.job == 'cts' || inputs.job == 'codegen' }}
uses: actions/cache@v2
with:
path: clients/algoliasearch-client-javascript/packages/client-insights
Expand All @@ -182,7 +291,7 @@ runs:
)}}

- name: Restore built JavaScript sources client
if: ${{ inputs.job == 'cts' }}
if: ${{ inputs.job == 'cts' || inputs.job == 'codegen' }}
uses: actions/cache@v2
with:
path: clients/algoliasearch-client-javascript/packages/client-sources
Expand All @@ -195,7 +304,7 @@ runs:
)}}

- name: Restore built JavaScript predict client
if: ${{ inputs.job == 'cts' }}
if: ${{ inputs.job == 'cts' || inputs.job == 'codegen' }}
uses: actions/cache@v2
with:
path: clients/algoliasearch-client-javascript/packages/client-predict
Expand All @@ -207,16 +316,29 @@ runs:
'specs/bundled/predict.yml'
)}}

# Restore Java clients: used during 'cts'
# Restore Java clients: used during 'cts' or 'codegen'
- name: Restore built Java client
if: ${{ inputs.job == 'cts' }}
if: ${{ inputs.job == 'cts' || inputs.job == 'codegen' }}
uses: actions/cache@v2
with:
path: clients/algoliasearch-client-java-2
key: |
${{ env.CACHE_VERSION }}-${{
hashFiles(
'clients/algoliasearch-client-java-2/client-predict/**',
'!clients/algoliasearch-client-java-2/client-predict/target',
'clients/algoliasearch-client-java-2/**',
'!clients/algoliasearch-client-java-2/target',
'specs/bundled/search.yml'
)}}

# Restore PHP clients: used during 'cts' or 'codegen'
- name: Restore built PHP client
if: ${{ inputs.job == 'cts' || inputs.job == 'codegen' }}
uses: actions/cache@v2
with:
path: clients/algoliasearch-client-php
key: |
${{ env.CACHE_VERSION }}-${{
hashFiles(
'clients/algoliasearch-client-php/*',
'specs/bundled/search.yml'
)}}
Loading