test(ci): add tests for release process #241
Conversation
|
✔️ Deploy Preview for api-clients-automation canceled. 🔨 Explore the source changes: d68ccee 🔍 Inspect the deploy log: https://app.netlify.com/sites/api-clients-automation/deploys/622a0f3a489db20008a4d947 |
| it('returns error when language scope is missing', () => { | ||
| expect(parseCommit(`abcdefg fix: fix the thing`)).toEqual({ | ||
| error: 'missing-language-scope', | ||
| }); | ||
| }); | ||
|
|
||
| it('returns error when language scope is unknown', () => { | ||
| expect(parseCommit(`abcdefg fix(basic): fix the thing`)).toEqual({ | ||
| error: 'unknown-language-scope', | ||
| }); | ||
| }); |
There was a problem hiding this comment.
shouldn't it be a throw or we handle this error?
There was a problem hiding this comment.
It returns error and prints some warning logs.
Assuming most of the commits follow semantic rules, some of commits might slip through (like "Merge ...."), and it shouldn't fail the release process. We can just ignore those commits and exclude from the changelogs, and versioning process.
There was a problem hiding this comment.
Yep that make sense, but I believe it would also make sense to have an error log in that case (maybe a file like yarn does for example, or a commit, or msg to slack).
Otherwise, we might not see the error and have release with missing commits, it might be intended to skip that commit in particular but it could also be a mistake on our side.
There was a problem hiding this comment.
Oh I'm dumb it's in the issue then ._.
There was a problem hiding this comment.
Oh, it's not in the issue, but we should definitely include them in the issue, like
Expand to see skipped commit messages:
lack of language scope
abcdefg fix: fix this
unknown language scope
abcdefg fix(blah): fix this
lack of language scope
abcdefg fix: fix this
unknown language scope
abcdefg fix(blah): fix this
I can do this in a separate PR.
There was a problem hiding this comment.
Yep it make sense then, we definitely need to track those
* test(ci): add tests for release process * chore: update test case * chore: update tests
🧭 What and Why
Changes included:
I'm going to change the release process a bit, and need some tests to make sure the changes won't fail.
🧪 Test