feat: (APIC-190) Add manage indices endpoints #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millotp
reviewed
Dec 1, 2021
|
(We should wait for #21 before merging this one) |
millotp
reviewed
Dec 2, 2021
clients/algoliasearch-client-javascript/client-search/src/searchApi.ts
Outdated
Show resolved
Hide resolved
shortcuts
reviewed
Dec 2, 2021
Comment on lines
+42
to
+46
| properties: | ||
| taskID: | ||
| $ref: '../../../common/parameters.yml#/taskID' | ||
| updatedAt: | ||
| $ref: '../../../common/parameters.yml#/updatedAt' |
There was a problem hiding this comment.
Is there a way to make those response properties not optional? I see that we have that everywhere, while it shouldn't be the case
(Shouldn't be fixed in this PR IMO since it needs to be applied on every responses)
clients/algoliasearch-client-javascript/client-search/model/listIndicesResponse.ts
Show resolved
Hide resolved
millotp
approved these changes
Dec 2, 2021
shortcuts
pushed a commit
that referenced
this pull request
Apr 22, 2022
This was referenced May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added :
/1/indexes/{indexName}/operation(copy/move index) : https://www.algolia.com/doc/rest-api/search/#copymove-index/1/indexes(list indices): https://www.algolia.com/doc/rest-api/search/#list-indices/1/indexes/{indexName}(delete method from the already existing search endpoint) (delete index) : https://www.algolia.com/doc/rest-api/search/#delete-index