-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): refine release process #238
Conversation
✔️ Deploy Preview for api-clients-automation ready! 🔨 Explore the source changes: beded3c 🔍 Inspect the deploy log: https://app.netlify.com/sites/api-clients-automation/deploys/6228cbcb29965b0008a18fea 😎 Browse the preview: https://deploy-preview-238--api-clients-automation.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks nice, could you please explain quickly the whole process using the temp folder so I can have a global understanding of it ? :)
config/release.config.json
Outdated
@@ -1,7 +1,7 @@ | |||
{ | |||
"releasedTag": "released", | |||
"mainBranch": "main", | |||
"owner": "algolia", | |||
"owner": "eunjae-lee", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I probably missed this, but why is it needed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch! I put it there in my fork, and now I need to revert it!
@damcou I updated the description. Let me know if you need more clarification :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Small questions
Co-authored-by: Clément Vannicatte <20689156+shortcuts@users.noreply.github.com>
…s-automation into chore/release-process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:okidoki:
* chore(ci): refine release process * chore: create tag if env var is given * chore: revert test code * Update scripts/common.ts Co-authored-by: Clément Vannicatte <20689156+shortcuts@users.noreply.github.com> * chore: add comment Co-authored-by: Clément Vannicatte <20689156+shortcuts@users.noreply.github.com>
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-360
Changes included:
Release process regarding temp folder
When a release issue is approved and merged,
process-release.ts
is triggered. GitHub Action exposes an environment variable namedRUNNER_TEMP
, which is a temporary directory like/tmp
.process-release.ts
generates clients🧪 Test