Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): refine release process #238

Merged
merged 7 commits into from
Mar 10, 2022
Merged

chore(ci): refine release process #238

merged 7 commits into from
Mar 10, 2022

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Mar 8, 2022

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-360

Changes included:

  • Remove submodule-related code
  • Clone each repositories under temp folder, copy changes, and push

Release process regarding temp folder

When a release issue is approved and merged, process-release.ts is triggered. GitHub Action exposes an environment variable named RUNNER_TEMP, which is a temporary directory like /tmp.

  1. process-release.ts generates clients
  2. clones js, php, java, ... repositories under the temp folder.
  3. copies the generation over to those folders
  4. commit, tag and push to each repository
  5. commit changes on monorepo (openapitools.json, and changelogs) and push to remote

🧪 Test

  • CI

@netlify
Copy link

netlify bot commented Mar 8, 2022

✔️ Deploy Preview for api-clients-automation ready!

🔨 Explore the source changes: beded3c

🔍 Inspect the deploy log: https://app.netlify.com/sites/api-clients-automation/deploys/6228cbcb29965b0008a18fea

😎 Browse the preview: https://deploy-preview-238--api-clients-automation.netlify.app

@eunjae-lee eunjae-lee requested review from a team, damcou, millotp and shortcuts and removed request for a team March 8, 2022 10:48
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice, could you please explain quickly the whole process using the temp folder so I can have a global understanding of it ? :)

@@ -1,7 +1,7 @@
{
"releasedTag": "released",
"mainBranch": "main",
"owner": "algolia",
"owner": "eunjae-lee",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I probably missed this, but why is it needed ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! I put it there in my fork, and now I need to revert it!

@eunjae-lee
Copy link
Contributor Author

This looks nice, could you please explain quickly the whole process using the temp folder so I can have a global understanding of it ? :)

@damcou I updated the description. Let me know if you need more clarification :)

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Small questions

eunjae-lee and others added 4 commits March 9, 2022 15:54
Co-authored-by: Clément Vannicatte <20689156+shortcuts@users.noreply.github.com>
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:okidoki:

@eunjae-lee eunjae-lee merged commit 2481779 into main Mar 10, 2022
@eunjae-lee eunjae-lee deleted the chore/release-process branch March 10, 2022 10:26
shortcuts added a commit that referenced this pull request Apr 22, 2022
* chore(ci): refine release process

* chore: create tag if env var is given

* chore: revert test code

* Update scripts/common.ts

Co-authored-by: Clément Vannicatte <20689156+shortcuts@users.noreply.github.com>

* chore: add comment

Co-authored-by: Clément Vannicatte <20689156+shortcuts@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants