Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(script): build javascript-algoliasearch after other clients #223

Merged
merged 6 commits into from
Mar 3, 2022

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

bug nb 1239234 regarding javascript-algoliasearch

As the JavaScript algoliasearch client needs generated clients to be built, we can encounter race issue when clients are not built in the right order.

This PR exclude the javascript-algoliasearch client from the generators and runs it after.

🧪 Test

CI :D

@shortcuts shortcuts requested a review from millotp March 2, 2022 15:21
@shortcuts shortcuts self-assigned this Mar 2, 2022
@netlify
Copy link

netlify bot commented Mar 3, 2022

✔️ Deploy Preview for api-clients-automation canceled.

🔨 Explore the source changes: 229cd11

🔍 Inspect the deploy log: https://app.netlify.com/sites/api-clients-automation/deploys/6220c92d67bd11000751c36c

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love race condition, they always pop in the most random place. Maybe listr could help solve that.

@shortcuts shortcuts enabled auto-merge (squash) March 3, 2022 14:01
@shortcuts shortcuts requested a review from millotp March 3, 2022 14:01
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants