Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): add startDate and endDate query parameter to list events #2229

Merged
merged 3 commits into from
Nov 9, 2023
Merged

feat(specs): add startDate and endDate query parameter to list events #2229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a9f278
feat(specs): add `window` parameter to list events
shortcuts Nov 9, 2023
f5fe101
fix: inline
shortcuts Nov 9, 2023
9b02b8d
Merge branch 'main' into fix/specs-ingestion-window-query-parameters
shortcuts Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions specs/ingestion/common/observabilityParameters.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,23 +57,3 @@ eventSortKeys:
type: string
description: Used to sort the Event list endpoint.
enum: [status, type, publishedAt]

startDate:
name: startDate
in: query
description: >
The start date (in RFC3339 format) of the runs fetching window.

Defaults to 'now'-7 days if omitted. The timespan between `startDate` and `endDate` must be smaller than 7 days.
schema:
type: string

endDate:
name: endDate
in: query
description: >
The end date (in RFC3339 format) of the runs fetching window.

Defaults to 'now' days if omitted. The timespan between `startDate` and `endDate` must be smaller than 7 days.
schema:
type: string
10 changes: 10 additions & 0 deletions specs/ingestion/paths/runs/events/events.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,16 @@ get:
- $ref: '../../../common/observabilityParameters.yml#/eventType'
- $ref: '../../../common/observabilityParameters.yml#/eventSort'
- $ref: '../../../common/parameters.yml#/order'
- name: startDate
in: query
description: The start date (in RFC3339 format) of the events fetching window. Defaults to 'now'-3 hours if omitted.
schema:
type: string
- name: endDate
in: query
description: The end date (in RFC3339 format) of the events fetching window. Defaults to 'now' days if omitted.
schema:
type: string
responses:
'200':
description: OK
Expand Down
12 changes: 10 additions & 2 deletions specs/ingestion/paths/runs/runs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,16 @@ get:
- $ref: '../../common/observabilityParameters.yml#/taskID'
- $ref: '../../common/observabilityParameters.yml#/runSort'
- $ref: '../../common/parameters.yml#/order'
- $ref: '../../common/observabilityParameters.yml#/startDate'
- $ref: '../../common/observabilityParameters.yml#/endDate'
- name: startDate
in: query
description: The start date (in RFC3339 format) of the runs fetching window. Defaults to 'now'-7 days if omitted.
schema:
type: string
- name: endDate
in: query
description: The end date (in RFC3339 format) of the runs fetching window. Defaults to 'now' days if omitted.
schema:
type: string
responses:
'200':
description: OK
Expand Down