Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(go): update go docs #2200

Merged
merged 7 commits into from
Nov 9, 2023
Merged

chore(go): update go docs #2200

merged 7 commits into from
Nov 9, 2023

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Oct 30, 2023 •
edited by jira bot
Loading

🧭 What and Why

🎟 JIRA Ticket: DI-1589

Changes included:

  • Add installation documentation
  • Add generic text for migration document
  • Add examples for each main operation.

@Fluf22 Fluf22 self-assigned this Oct 30, 2023
@Fluf22 Fluf22 requested a review from a team as a code owner October 30, 2023 15:11
@Fluf22 Fluf22 requested review from damcou and shortcuts October 30, 2023 15:11
@netlify
Copy link

netlify bot commented Oct 30, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit e211656
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/654cf2c3a9124000081563b5
😎 Deploy Preview https://deploy-preview-2200--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Fluf22 Fluf22 requested a review from aallam October 30, 2023 15:11
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 30, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@Fluf22 Fluf22 force-pushed the chore/update-go-docs branch 3 times, most recently from 4f8ccfa to 5a5b5a8 Compare October 30, 2023 17:11
aallam
aallam reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@aallam aallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I have just a question :D

shortcuts
shortcuts previously approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUPER clean, no blockers on my side gg for tackling this

@Fluf22 Fluf22 force-pushed the chore/update-go-docs branch from d6e5d2e to f345bfb Compare November 9, 2023 10:09
@Fluf22 Fluf22 enabled auto-merge (squash) November 9, 2023 13:27
@Fluf22 Fluf22 merged commit 80a6f2b into main Nov 9, 2023
@Fluf22 Fluf22 deleted the chore/update-go-docs branch November 9, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aallam aallam aallam approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

@shortcuts shortcuts Awaiting requested review from shortcuts

@millotp millotp Awaiting requested review from millotp

Assignees

@Fluf22 Fluf22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Fluf22 @algolia-bot @aallam @millotp @shortcuts