Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(go): wait task and api key operation helpers #2117

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Oct 13, 2023

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

  • add WaitForTask and WaitForApiKey helpers
  • add WaitErrs
  • add docs

🧪 Test

Tested in the playground.

@Fluf22 Fluf22 self-assigned this Oct 13, 2023
@Fluf22 Fluf22 requested a review from a team as a code owner October 13, 2023 16:07
@Fluf22 Fluf22 requested review from aallam and shortcuts October 13, 2023 16:07
@netlify
Copy link

netlify bot commented Oct 13, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit e8e2105
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/652e4fe0bc0c0e0008267ab8
😎 Deploy Preview https://deploy-preview-2117--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 13, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@Fluf22 Fluf22 changed the title Feat/go wait task feat(go): wait task and api key operation helpers Oct 13, 2023
Copy link
Contributor Author

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to document the context props

Copy link
Member

@aallam aallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ 🙌

@Fluf22 Fluf22 force-pushed the feat/go-wait-task branch from 2d82a0d to c30f9f2 Compare October 16, 2023 16:21
@Fluf22 Fluf22 requested a review from aallam October 17, 2023 09:19
Copy link
Member

@aallam aallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's GO! 🚀

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG!!

panic(err)
}

taskResponse, err := searchClient.WaitForApiKey(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we definitely need golangci lint ahah

@Fluf22 Fluf22 merged commit 2062fa8 into main Oct 17, 2023
@Fluf22 Fluf22 deleted the feat/go-wait-task branch October 17, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants