fix(cts): improve oneOf matching with enum #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
millotp
commented
Aug 31, 2023
Comment on lines
-88
to
-90
| lambdas.put("escapeReserved", new EscapeDartLambda()); | ||
| lambdas.put("escapeDollarSign", new EscapeDollarSignLambda()); | ||
| lambdas.put("lowerCamelCase", new LowerCamelCaseLambda()); |
There was a problem hiding this comment.
do you know the use case for those lambdas @aallam ?
There was a problem hiding this comment.
I remember some of them where used for dart, but I can't find the usage anymore! maybe got refactored away!
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
reviewed
Aug 31, 2023
|
yes this is like a discriminator, but automatic 😀 |
shortcuts
approved these changes
Aug 31, 2023
|
yeah I'm not sure why I'll try to make it work in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: DI-1384
Fix oneOf matching for
EventItem, by checking that the enum string is allowed.It uses the tests cases added and removed in #1647.
Also clean up unused lambdas.