Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): add client utils to build process #179

Merged
merged 10 commits into from
Mar 1, 2022
Merged

fix(ci): add client utils to build process #179

merged 10 commits into from
Mar 1, 2022

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Feb 25, 2022 •
edited
Loading

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-347

Changes included:

  • Add algoliasearch to the CI
  • Allow building utils and algoliasearch packages from the scripts

🧪 Test

CI :D

@shortcuts shortcuts force-pushed the fix/ci-algoliasearch branch 4 times, most recently from e807207 to 2394858 Compare February 25, 2022 16:02
@shortcuts shortcuts force-pushed the fix/ci-algoliasearch branch from 2394858 to 3fb6913 Compare February 25, 2022 16:09
@shortcuts shortcuts changed the title fix(ci): build algoliasearch with clients fix(ci): add client utils to build process Feb 28, 2022
@shortcuts shortcuts requested a review from millotp February 28, 2022 10:44
@shortcuts shortcuts self-assigned this Feb 28, 2022
@shortcuts
Copy link
Member Author

Waiting for #183

@shortcuts shortcuts marked this pull request as ready for review February 28, 2022 10:49
@shortcuts shortcuts enabled auto-merge (squash) February 28, 2022 14:50
millotp
millotp reviewed Feb 28, 2022
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work ! A lot easier to review with ts

@shortcuts shortcuts requested a review from millotp February 28, 2022 17:04
@shortcuts shortcuts mentioned this pull request Mar 1, 2022
Merged
@shortcuts shortcuts merged commit 2d46e6f into main Mar 1, 2022
@shortcuts shortcuts deleted the fix/ci-algoliasearch branch March 1, 2022 10:41
shortcuts added a commit that referenced this pull request Apr 22, 2022
@shortcuts
fix(ci): add client utils to build process (#179)
0064850
This was referenced May 24, 2022
Closed
Closed
This was referenced May 25, 2022
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shortcuts @millotp