fix(scripts): release script with ssh #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shortcuts
commented
Jul 18, 2023
| @@ -246,7 +246,7 @@ export function ensureGitHubToken(): string { | |||
| if (!process.env.GITHUB_TOKEN) { | |||
| throw new Error('Environment variable `GITHUB_TOKEN` does not exist.'); | |||
| } | |||
| return process.env.GITHUB_TOKEN; | |||
| return process.env.GITHUB_TOKEN.replaceAll('"', ''); | |||
There was a problem hiding this comment.
I fixed my env var of course but lets keep this in case someone also puts them for strings
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp
approved these changes
Jul 18, 2023
| @@ -5,7 +5,7 @@ | |||
| "scripts": { | |||
| "cleanGeneratedBranch": "ts-node ci/codegen/cleanGeneratedBranch.ts", | |||
| "createMatrix": "ts-node ci/githubActions/createMatrix.ts", | |||
| "createReleasePR": "ts-node release/createReleasePR.ts", | |||
| "createReleasePR": "NODE_NO_WARNINGS=1 ts-node release/createReleasePR.ts", | |||
There was a problem hiding this comment.
when will this be stable ?
427ca7c to
3102ae5
Compare
|
my rebase was broken, better now, sorry |
millotp
approved these changes
Jul 18, 2023
This was referenced Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
ssh via docker was broken because: