Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: optimize docker image #1770

Merged
merged 8 commits into from
Jul 17, 2023
Merged

chore: optimize docker image #1770

merged 8 commits into from
Jul 17, 2023

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

tried to make the dockerfile a bit more easier to navigate and reduce the size, it was 2.5gb before, now it's 1.5xgb

@shortcuts shortcuts self-assigned this Jul 17, 2023
@shortcuts shortcuts requested a review from a team as a code owner July 17, 2023 07:08
@shortcuts shortcuts requested review from damcou and aallam July 17, 2023 07:08
@netlify
Copy link

netlify bot commented Jul 17, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit fd27d95
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/64b50dcbf8106b00086a6861
😎 Deploy Preview https://deploy-preview-1770--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 17, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

millotp
millotp reviewed Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice improvement ! much more readable

@shortcuts shortcuts force-pushed the chore/slimmer-docker-images branch from 008a056 to 7bd8f0d Compare July 17, 2023 08:36
aallam
aallam previously approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@aallam aallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! GJ! 🚀

millotp
millotp previously approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good !

@shortcuts shortcuts requested review from millotp and aallam July 17, 2023 10:04
@shortcuts shortcuts mentioned this pull request Jul 17, 2023
Merged
@shortcuts shortcuts merged commit 945869f into main Jul 17, 2023
@shortcuts shortcuts deleted the chore/slimmer-docker-images branch July 17, 2023 11:47
@algolia-bot algolia-bot mentioned this pull request Jul 18, 2023
Closed
This was referenced Jul 18, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

@aallam aallam Awaiting requested review from aallam

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shortcuts @algolia-bot @aallam @millotp