Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: only setup dart when required #1731

Merged
merged 2 commits into from
Jul 11, 2023
Merged

chore: only setup dart when required #1731

merged 2 commits into from
Jul 11, 2023

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-1420

Changes included:

we setup dart for every clients but only need it for the release or the dart client itself

@shortcuts shortcuts self-assigned this Jul 11, 2023
@netlify
Copy link

netlify bot commented Jul 11, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit eb29a0e
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/64ad64def918030008810aed
😎 Deploy Preview https://deploy-preview-1731--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 11, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts shortcuts marked this pull request as ready for review July 11, 2023 14:31
@shortcuts shortcuts requested a review from a team as a code owner July 11, 2023 14:31
@shortcuts shortcuts requested review from damcou and aallam July 11, 2023 14:31
millotp
millotp approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@shortcuts shortcuts merged commit 7f76fd2 into main Jul 11, 2023
@shortcuts shortcuts deleted the chore/conditional-dart-setup branch July 11, 2023 14:40
@algolia-bot algolia-bot mentioned this pull request Jul 18, 2023
Closed
This was referenced Jul 18, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

@aallam aallam Awaiting requested review from aallam aallam is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shortcuts @algolia-bot @millotp