Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cts): generate lock and package.json for javascript #1721

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

an other bug discovered in #1683, the package.json for the JavaScript client tests were outdated and manually created, now they are fully generated

@shortcuts shortcuts self-assigned this Jul 10, 2023
@shortcuts shortcuts requested a review from a team as a code owner July 10, 2023 15:31
@shortcuts shortcuts requested review from morganleroi and Fluf22 July 10, 2023 15:31
@netlify
Copy link

netlify bot commented Jul 10, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit dd62c31
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/64ac258d1cc1d60008f5073d
😎 Deploy Preview https://deploy-preview-1721--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 10, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Fluf22
Fluf22 previously approved these changes Jul 10, 2023
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice !

@shortcuts shortcuts enabled auto-merge (squash) July 10, 2023 15:38
@shortcuts shortcuts merged commit 8827b72 into main Jul 10, 2023
@shortcuts shortcuts deleted the fix/cts-javascript branch July 10, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants