Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(specs): Review OpenAPI Search API (dictionary operations) #1700

Merged

Conversation

gazconroy
Copy link
Contributor

@gazconroy gazconroy commented Jul 6, 2023

🧭 What and Why

This is one of several PRs addressing the Search API.

This PR reviews just the dictionary operations of the Search API.

Questions and notes

setDictionarySettings

Plurals and compounds are part of the standardEntries object but only stop words are supported by the API call. Should the OAS change?

🎟 JIRA Ticket: DOC-1107

Changes included:

Changes to summary, description and examples

🧪 Test

@gazconroy gazconroy requested a review from a team as a code owner July 6, 2023 12:18
@gazconroy gazconroy requested review from Fluf22 and shortcuts and removed request for a team July 6, 2023 12:18
@netlify
Copy link

netlify bot commented Jul 6, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 09bf880
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/64ad5975e130c20007890200
😎 Deploy Preview https://deploy-preview-1700--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 6, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@gazconroy gazconroy force-pushed the fix/openapi-review-search-dictionary branch from af803d7 to 0ad5aec Compare July 10, 2023 08:49
gazconroy and others added 3 commits July 11, 2023 14:29
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Copy link
Contributor

@kai687 kai687 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for final review by API clients team.

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect4!

@shortcuts shortcuts merged commit 50450cf into fix/review-common-specs Jul 11, 2023
@shortcuts shortcuts deleted the fix/openapi-review-search-dictionary branch July 11, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants