Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(specs): Review OpenAPI Search API (record operations) #1697

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

gazconroy
Copy link
Contributor

🧭 What and Why

This is one of several PRs addressing the Search API.

This PR reviews just the record operations of the Search API.

Questions and notes

partialUpdateObject

Is there a better way to phrase this? It’s difficult to understand.

“If you specify a nested attribute, the engine treats it as a replacement of its first-level ancestor.”

🎟 JIRA Ticket: DOC-1107

Changes included:

Changes to summary, description and examples

🧪 Test

@gazconroy gazconroy requested a review from a team as a code owner July 6, 2023 10:50
@gazconroy gazconroy requested review from Fluf22 and mehmetaligok and removed request for a team July 6, 2023 10:50
@netlify
Copy link

netlify bot commented Jul 6, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit b6c91c7
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/64abdec28b3604000873d800
😎 Deploy Preview https://deploy-preview-1697--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 6, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@gazconroy gazconroy requested a review from kai687 July 6, 2023 12:11
@gazconroy gazconroy force-pushed the fix/openapi-review-search-records branch from bc0047e to 81c4bb7 Compare July 10, 2023 08:45
Copy link
Contributor

@kai687 kai687 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for final review by the team.

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great ! Do you want this to be merged directly ?

@kai687
Copy link
Contributor

kai687 commented Jul 11, 2023

@millotp yes, this can be merged.

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!!

(please wait for the monitoring client to be generated, just making sure it works properly)

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely

@shortcuts shortcuts merged commit 41aa510 into fix/review-common-specs Jul 11, 2023
@shortcuts shortcuts deleted the fix/openapi-review-search-records branch July 11, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants