-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(specs): Review OpenAPI Search API (record operations) #1697
docs(specs): Review OpenAPI Search API (record operations) #1697
Conversation
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
bc0047e
to
81c4bb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for final review by the team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great ! Do you want this to be merged directly ?
@millotp yes, this can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!!
(please wait for the monitoring client to be generated, just making sure it works properly)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lovely
🧭 What and Why
This is one of several PRs addressing the Search API.
This PR reviews just the record operations of the Search API.
Questions and notes
partialUpdateObject
Is there a better way to phrase this? It’s difficult to understand.
“If you specify a nested attribute, the engine treats it as a replacement of its first-level ancestor.”
🎟 JIRA Ticket: DOC-1107
Changes included:
Changes to summary, description and examples
🧪 Test