Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(specs): Review OpenAPI Search API (index operations) #1696

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

gazconroy
Copy link
Contributor

@gazconroy gazconroy commented Jul 6, 2023

🧭 What and Why

This is one of several PRs addressing the Search API.

This PR reviews just the index operations of the Search API.

Questions and notes

operationIndex

  • Original content says “ You can't move a source index that has replicas.” but that appears not to be true. I can carry out a move operation on an index with replicas. It won’t rename the original but, instead, creates an empty index with the destination name. Should this be stated?

listIndices

  • The page parameter requires a hitsPerPage parameter to make any sense/return sensible results. This was missing in the original OAS, I’ve added it but is the default of 100 correct?

getSettings

  • In the response, allowCompressionOfIntegerArray notes say “If true, the engine applies a better compression ratio. This is recommended for arrays containing non-negative integers. When enabled, the compressed arrays may be reordered.”

    What’s the user benefit in compressing arrays? Is there any performance impact?

    In the final sentence does this mean that the engine might reorder the array? Could this pose issues?

  • In the response, what's the difference between facetOrdering and facets?

🎟 JIRA Ticket: DOC-1107

Changes included:

Changes to summary, description and examples

🧪 Test

@gazconroy gazconroy requested a review from a team as a code owner July 6, 2023 10:38
@gazconroy gazconroy requested review from morganleroi and shortcuts and removed request for a team July 6, 2023 10:38
@netlify
Copy link

netlify bot commented Jul 6, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 4485662
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/64ad3a5c1440be0008ba65cf
😎 Deploy Preview https://deploy-preview-1696--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 6, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@gazconroy gazconroy changed the title Fix/openapi review search indices docs(specs): Review OpenAPI Search API (index operations) Jul 6, 2023
@gazconroy gazconroy requested a review from kai687 July 6, 2023 10:41
@gazconroy gazconroy force-pushed the fix/openapi-review-search-indices branch from 802d79a to eab43f7 Compare July 10, 2023 08:28
Copy link
Contributor

@kai687 kai687 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for final review by the team.

@shortcuts shortcuts merged commit f6921f5 into fix/review-common-specs Jul 11, 2023
@shortcuts shortcuts deleted the fix/openapi-review-search-indices branch July 11, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants