Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add release using docker #1690

Merged
merged 3 commits into from
Jul 4, 2023
Merged

chore: add release using docker #1690

merged 3 commits into from
Jul 4, 2023

Conversation

aallam
Copy link
Member

@aallam aallam commented Jul 4, 2023

🧭 What and Why

This PR aims to streamline the process of creating release PRs for Docker images.
We can now use the yarn docker:release command to create a release PR.

🎟 JIRA Ticket: APIC-699

Changes included:

  • Added docker:release command in package.json.
  • Modified Dockerfile to install git during the Docker image build process.

GITHUB_TOKEN environment variable is required to run the release command.

@aallam aallam requested a review from a team as a code owner July 4, 2023 13:27
@aallam aallam requested review from morganleroi and Fluf22 July 4, 2023 13:27
@netlify
Copy link

netlify bot commented Jul 4, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit f8659c6
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/64a4243a42a68e0007798654
😎 Deploy Preview https://deploy-preview-1690--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 4, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

shortcuts
shortcuts previously approved these changes Jul 4, 2023
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's nice!

millotp
millotp previously approved these changes Jul 4, 2023
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very fancy

@aallam aallam enabled auto-merge (squash) July 4, 2023 14:03
@aallam aallam merged commit 1a6ca3d into main Jul 4, 2023
@aallam aallam deleted the chore/release-docker branch July 4, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants