-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(specs): Review OpenAPI Analytics (search analytics) #1689
docs(specs): Review OpenAPI Analytics (search analytics) #1689
Conversation
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for final review by API clients team
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
This is one of several PRs addressing the Analytics API.
This PR reviews just the search operations of the Analytics API.
🧭 What and Why
Questions and notes
In the docs, there are 15 API calls. In the OAS, just 12. Should the missing calls be added to the OAS?
getTopSearches
count
is always (much) smaller thannbHits
(whatever the setting ofclickAnalytics
). This doesn’t seem intuitive. What’s the difference betweencount
andnbHits
?clickPositions
object which isn’t defined in the OASgetSearchesCountResponse
withFilterCount
field in the searches object which isn’t defined in the OASgetNoResultsRate
noResultCount
? I’ve put in the placeholder “Number of occurrences” but that's not very helpfulnoClickCount
is defined as “Number of click events.” This doesn’t seem to be correct in this contextgetTopHits
getTopHits
getTopFilterAttributes/getTopFilterForAttribute/getTopFiltersNoResults
getTopFilterForAttribute
operator
is returned as:
. What does that indicate? What are the potential settings foroperator
?getTopFiltersNoResults
{"values": null}
getTopCountries
{"values": null}
🎟 JIRA Ticket: DOC-1112
Changes included:
Changes to summary, description and examples
🧪 Test