fix(cts): allow different ordering of oneOf schema
#1654
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
5 tasks
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
|
shoot, not everywhere |
|
this can't work with the current way of generating the CTS, will try further with an other solution |
|
@shortcuts let me know if this is too much trouble. We can just use a single request body and iterate at a later time. |
it's fine we should be able to just remove the test for now, we know that the payload is corretly parsed anyway as we test other payload shape |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-1379
Changes included:
This PR makes the CTS code generation work for complex oneOf schemas like in #1647.
Today we only guess the matching oneOf by counting the number of matching elements, which is correct but enforce a specific order. The proposed solution is not more correct, but a bit looser as it doesn't enforce the element to be first in the oneOf matching list.
🧪 Test
This PR shouldn't impact the current CTS generation.