Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(specs): Review OpenAPI Search endpoint #1618

Closed
wants to merge 73 commits into from

Conversation

gazconroy
Copy link
Contributor

@gazconroy gazconroy commented Jun 15, 2023

WIP: Don't review yet.

Generic notes and notes about specific methods

🧭 What and Why

🎟 JIRA Ticket: DOC-1107

Changes included:

Work in progress content review...

🧪 Test

@gazconroy gazconroy requested a review from a team as a code owner June 15, 2023 13:45
@gazconroy gazconroy requested review from morganleroi and millotp June 15, 2023 13:45
@netlify
Copy link

netlify bot commented Jun 15, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 6ee2bac
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/64a5636a7953a70008df8a35
😎 Deploy Preview https://deploy-preview-1618--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gazconroy gazconroy marked this pull request as draft June 15, 2023 13:46
@shortcuts
Copy link
Member

Thanks for doing this!! 💓

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 15, 2023

🔨 The codegen job will run at the end of the CI.

Make sure your last commit does not contain generated code, it will be automatically pushed by our CI.

@gazconroy gazconroy requested a review from kai687 June 15, 2023 13:47
Copy link
Contributor

@kai687 kai687 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have severe review fatigue after reviewing 18 of 67 files. This is too much for a single PR.

DOC-1115 was about the search endpoints, while DOC-1116 was about the Search API parameters. It may be better to split each task even more into synonym stuff, search stuff, rules stuff, etc.

Copy link
Contributor

@kai687 kai687 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have severe review fatigue after reviewing 18 of 67 files. This is too much for a single PR.

DOC-1115 was about the search endpoints, while DOC-1116 was about the Search API parameters. It may be better to split each task even more into synonym stuff, search stuff, rules stuff, etc.

gazconroy and others added 11 commits July 5, 2023 10:56
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
@gazconroy gazconroy closed this Jul 5, 2023
@millotp millotp deleted the fix/openapi-review-search branch July 12, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants