-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(specs): Review OpenAPI Search endpoint #1618
Conversation
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for doing this!! 💓 |
🔨 The codegen job will run at the end of the CI.Make sure your last commit does not contain generated code, it will be automatically pushed by our CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have severe review fatigue after reviewing 18 of 67 files. This is too much for a single PR.
DOC-1115 was about the search endpoints, while DOC-1116 was about the Search API parameters. It may be better to split each task even more into synonym stuff, search stuff, rules stuff, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have severe review fatigue after reviewing 18 of 67 files. This is too much for a single PR.
DOC-1115 was about the search endpoints, while DOC-1116 was about the Search API parameters. It may be better to split each task even more into synonym stuff, search stuff, rules stuff, etc.
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
Co-authored-by: Kai Welke <kai.welke@algolia.com>
WIP: Don't review yet.
Generic notes and notes about specific methods
🧭 What and Why
🎟 JIRA Ticket: DOC-1107
Changes included:
Work in progress content review...
🧪 Test