fix(specs): update required for kotlin tests to pass #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
7e7e558 to
7032ca4
Compare
12 tasks
shortcuts
reviewed
Apr 28, 2023
| @@ -53,7 +53,7 @@ | |||
| "sourceID": "search", | |||
| "destinationID": "destinationName", | |||
| "trigger": { | |||
| "type": "subscription" | |||
There was a problem hiding this comment.
Nope :/ The CTS generator consistently chooses the wrong type! Ideally, we should fix the CTS generator to properly handle this case, but that might be time-consuming. So, it's a problem to tackle another day!
There was a problem hiding this comment.
Make sense ty for the explanation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Fixes necessary API/CTS specifications for Kotlin API client to pass
Changes included: