Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): task trigger guard import order #1459

Merged
merged 2 commits into from
Apr 12, 2023
Merged

fix(specs): task trigger guard import order #1459

merged 2 commits into from
Apr 12, 2023

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Apr 12, 2023

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

Update task trigger guard import order so it matches the linter's

@Fluf22 Fluf22 self-assigned this Apr 12, 2023
@Fluf22 Fluf22 requested a review from a team as a code owner April 12, 2023 13:51
@Fluf22 Fluf22 requested review from morganleroi and millotp April 12, 2023 13:51
@netlify
Copy link

netlify bot commented Apr 12, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit e95d556
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/6436cd0838781a0008cbcf1c
😎 Deploy Preview https://deploy-preview-1459--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 12, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

shortcuts
shortcuts requested changes Apr 12, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good but waiting for release to be merged as it might break it otherwise

shortcuts
shortcuts approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noiiiiiiice

@Fluf22 Fluf22 enabled auto-merge (squash) April 12, 2023 15:23
@Fluf22 Fluf22 merged commit 69aac53 into main Apr 12, 2023
@Fluf22 Fluf22 deleted the fix/guard-import-order branch April 12, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

@millotp millotp Awaiting requested review from millotp millotp is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@Fluf22 Fluf22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fluf22 @algolia-bot @shortcuts