Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): task trigger guard update #1457

Merged
merged 1 commit into from
Apr 12, 2023
Merged

fix(specs): task trigger guard update #1457

merged 1 commit into from
Apr 12, 2023

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Apr 12, 2023

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

Update task trigger guard so we can use TaskCreateTrigger with them, since its signature changed

@Fluf22 Fluf22 requested a review from a team as a code owner April 12, 2023 12:55
@Fluf22 Fluf22 self-assigned this Apr 12, 2023
@Fluf22 Fluf22 requested review from aallam and shortcuts April 12, 2023 12:55
@netlify
Copy link

netlify bot commented Apr 12, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit d264cfb
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/6436aa321788a700077ee726
😎 Deploy Preview https://deploy-preview-1457--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 12, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point !

@Fluf22 Fluf22 enabled auto-merge (squash) April 12, 2023 12:59
@Fluf22 Fluf22 merged commit d3f107d into main Apr 12, 2023
@Fluf22 Fluf22 deleted the fix/task-trigger-guards branch April 12, 2023 13:03
@Fluf22
Copy link
Contributor Author

Fluf22 commented Apr 12, 2023

Oops!

Sorry, I thought I would be able to push without checking first locally 😭 Doing it right now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants