feat(go): add more playground examples #1447
Conversation
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
| analyticsClient := analytics.NewClient(appID, apiKey, analytics.US) | ||
|
|
||
| getTopFilterForAttributeResponse, err := analyticsClient.GetTopFilterForAttribute( | ||
| analyticsClient.NewApiGetTopFilterForAttributeRequest("myAttribute1,myAttribute2").WithIndex(indexName), |
There was a problem hiding this comment.
For a future improvement for DX, what about putting only the optional parameters inside an struct ? And keep the required ones at the first level
There was a problem hiding this comment.
tbh I also noticed that the required param can be handled in a better position, and already took a private note about it when creating these examples 😀
--
But directly removing from the struct may bring some other problems, I think more to add in the to New function for the request struct.
For example; using like analyticsClient.NewApiGetTopFilterForAttributeRequest("myAttribute1,myAttribute2", indexName) if the index name is required. So it would be more clear to user what is required when creating the request struct.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-664
More structured playground examples were added for the go client to give more examples to test.
Changes included:
🧪 Test
can be tested with
yarn docker playground go {client}