Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use cache to avoid building specs everytime APIC-283 #109

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jan 27, 2022

🧭 What and Why

🎟 JIRA Ticket: APIC-283

Compare the built spec to the real one and only build it if it changed, this way we can avoid 10 seconds of build spec (per client !) when doing yarn docker generate

Changes included:

  • Compute hash of spec and compare to stored one

🧪 Test

Run yarn docker generate javascript recommend twice for example.

@millotp millotp requested a review from damcou January 27, 2022 14:06
@millotp millotp self-assigned this Jan 27, 2022
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMAGAD it's working 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants