Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(recommend): Add Type RecommendQueriesResponse from old MultipleQueriesResponse for recommend #1472

Merged
merged 3 commits into from
Jul 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions packages/recommend/src/__tests__/getRecommendations.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,21 @@ import { TestSuite } from '../../../client-common/src/__tests__/TestSuite';

const recommend = new TestSuite('recommend').recommend;

function createMockedClient() {
function createMockedClient<TObject>() {
const client = recommend('appId', 'apiKey');
jest.spyOn(client.transporter, 'read').mockImplementation(() => Promise.resolve());
jest.spyOn(client.transporter, 'read').mockImplementation(() =>
Promise.resolve({
results: [
{
hits: [
{
objectID: '1',
},
],
},
],
})
);

return client;
}
Expand Down Expand Up @@ -197,4 +209,25 @@ describe('getRecommendations', () => {
{}
);
});

test('returns recommendations results', async () => {
const client = createMockedClient();

const recommendations = await client.getRecommendations<any>(
[
{
model: 'bought-together',
indexName: 'products',
objectID: 'B018APC4LE',
},
],
{}
);

expect(recommendations.results[0].hits).toEqual([
{
objectID: '1',
},
]);
});
});
21 changes: 14 additions & 7 deletions packages/recommend/src/types/WithRecommendMethods.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { MultipleQueriesResponse, SearchOptions } from '@algolia/client-search';
import { SearchOptions, SearchResponse } from '@algolia/client-search';
import { RequestOptions } from '@algolia/transporter';

import { FrequentlyBoughtTogetherQuery } from './FrequentlyBoughtTogetherQuery';
Expand All @@ -9,52 +9,59 @@ import { TrendingFacetsQuery } from './TrendingFacetsQuery';
import { TrendingItemsQuery } from './TrendingItemsQuery';
import { TrendingQuery } from './TrendingQuery';

export type RecommendQueriesResponse<TObject> = {
/**
* The list of results.
*/
readonly results: ReadonlyArray<SearchResponse<TObject>>;
};

export type WithRecommendMethods<TType> = TType & {
/**
* Returns recommendations.
*/
readonly getRecommendations: <TObject>(
queries: ReadonlyArray<RecommendationsQuery | TrendingQuery>,
requestOptions?: RequestOptions & SearchOptions
) => Readonly<Promise<MultipleQueriesResponse<TObject>>>;
) => Readonly<Promise<RecommendQueriesResponse<TObject>>>;

/**
* Returns [Related Products](https://algolia.com/doc/guides/algolia-ai/recommend/#related-products).
*/
readonly getRelatedProducts: <TObject>(
queries: readonly RelatedProductsQuery[],
requestOptions?: RequestOptions & SearchOptions
) => Readonly<Promise<MultipleQueriesResponse<TObject>>>;
) => Readonly<Promise<RecommendQueriesResponse<TObject>>>;

/**
* Returns [Frequently Bought Together](https://algolia.com/doc/guides/algolia-ai/recommend/#frequently-bought-together) products.
*/
readonly getFrequentlyBoughtTogether: <TObject>(
queries: readonly FrequentlyBoughtTogetherQuery[],
requestOptions?: RequestOptions & SearchOptions
) => Readonly<Promise<MultipleQueriesResponse<TObject>>>;
) => Readonly<Promise<RecommendQueriesResponse<TObject>>>;

/**
* Returns trending items
*/
readonly getTrendingItems: <TObject>(
queries: readonly TrendingItemsQuery[],
requestOptions?: RequestOptions & SearchOptions
) => Readonly<Promise<MultipleQueriesResponse<TObject>>>;
) => Readonly<Promise<RecommendQueriesResponse<TObject>>>;

/**
* Returns trending items per facet
*/
readonly getTrendingFacets: <TObject>(
queries: readonly TrendingFacetsQuery[],
requestOptions?: RequestOptions & SearchOptions
) => Readonly<Promise<MultipleQueriesResponse<TObject>>>;
) => Readonly<Promise<RecommendQueriesResponse<TObject>>>;

/**
* Returns Looking Similar
*/
readonly getLookingSimilar: <TObject>(
queries: readonly LookingSimilarQuery[],
requestOptions?: RequestOptions & SearchOptions
) => Readonly<Promise<MultipleQueriesResponse<TObject>>>;
) => Readonly<Promise<RecommendQueriesResponse<TObject>>>;
};