This repository has been archived by the owner on Jul 5, 2024. It is now read-only.
Use auth key derivation from API response #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @tigeryu8900, Thanks a lot for looking into this and putting together the PR. I haven't tested this change myself but it looks straightforward to me based on the issue so I am going to approve and merge this. To everyone else, if there are any issues coming from this change, please open a new issue and I'll take a look. |
alexzorin
approved these changes
Jun 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #30, the API response for
AuthenticatorTokennow includeskey_derivation_iterations, so I've modifieddecryptTokento use that value instead of a constant.Closes #30