This repository has been archived by the owner on Jan 11, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces Runtime permissions introduced in Android 6.0. When running in devices prior to 6.0 the app should behave the same as before.
On Android 6.0 the following permissions are requested:
READ_CONTACTS
Contact permission when accessing the Upcoming Events, Search and Date Details screen. The user is granted access if they grant the required permission. If no, the app closes.READ_EXTERNAL_STORAGE
When the user tries to select a Ringtone on the Daily Reminder screen, they are prompted to grant the said permission.NOTE: For some reason the
onActivityResult
of the DailyReminderActivity does not get called. That might be caused because of the custom version of PreferenceFragment we are using.Test(s) added
Yup. Around ContactPermissionRequest. Because of that this PR also introduces the
option in order to be able to test the Navigator class. At the initialisation of the class a Uri field was getting instantiated making the tests crash
Screenshots