This repository has been archived by the owner on Jan 11, 2021. It is now read-only.
Additional Analytics #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds additional analytic events to be tracked. It also modifies the way to track events through Firebase. Instead of using parameters, we are creating new events that have the different parameters bundle into the event name. This was done because parameters are not visible through the Firebase Analytics console. Because Analytics is an experimentation for the time being, the solutions would just work. The code is separate enough to switch out a different analytics implementation if needed.
Test(s) added
no. Unfortunately, Firebase analytics is a final class and cannot be mocked. Couldn't thought of any way of testing the class.
Screenshots
Nothing visual