This repository has been archived by the owner on Jan 11, 2021. It is now read-only.
Release resources onUnregisterObserver instead of onAbandon #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LeakCanary is picking up some memeory leaks narrowing down that
ContactsObserver
was leaking the activity's context it is being used.as it turns out, the problem was not the Observer itself, but it was not being released in each of the Loaders it is being used. In this PR, all resources are released on the
onUnregisterObserver()
instead ofonAbandon()
which might not be called while dismissing the Loader